Support provides/requires relationship in composite components #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for requires/provides relationships in composite components. The configuration parsed correctly, but the functionality was never added. This led to unexpected errors and an unintuitive experience. This PR officially adds the ability for composite components to
requirecomponents and access them in flows.POTENTIAL BREAKING NOTE: This PR makes the order of
import-ed components important. During the changes above, I saw some random test failures that stemmed from the indeterministic ordering of rust'sHashMapkeys. This PR changes those structures to lists which will make them reliable but order-dependent. Components must now be imported in an earlier position than they are provided to other components.