Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use const/let in sample code #3846

Closed
chasenlehara opened this issue Jan 19, 2018 · 2 comments
Closed

Use const/let in sample code #3846

chasenlehara opened this issue Jan 19, 2018 · 2 comments
Assignees

Comments

@chasenlehara
Copy link
Member

It’d be nice for all of the code in our guides and core APIs to show const/let; extra points for having all of our example code show const/let instead of var.

Note that this is not talking about the source code, where we intend to continue using what’s supported by the browsers we support.

@christopherjbaker
Copy link
Contributor

The following PRs have been opened:

@chasenlehara
Copy link
Member Author

This has not been finished.

@chasenlehara chasenlehara reopened this Mar 14, 2018
phillipskevin added a commit that referenced this issue Jul 16, 2018
Replaces var with let/const in the canjs/docs files. Fixes #3846 & addresses #4116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants