-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ref): add VHAL HTTP API documentation #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update the doc cheat sheet
ref/anbox-https-api.md
Outdated
"metadata": { | ||
"value": { | ||
"area_id": 49, # Requested area. | ||
"bytes": [], # Raw bytes value as an 8-bit unsigned integer array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question I left on the MP, do we need to keep the field when its value is empty? Same for int32_values/int64_values and others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rework serialization in a follow-up MP.
For now, I prefer to have the documentation reflect what's actually in the code: if we omit the fields in the future, I will update the documentation and remove them (or explain that they may be omitted).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
668d3db
to
187b8ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ref/anbox-https-api.md
Outdated
"metadata": { | ||
"value": { | ||
"area_id": 49, # Requested area. | ||
"bytes": [], # Raw bytes value as an 8-bit unsigned integer array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me .
187b8ad
to
fc8524c
Compare
This adds VHAL endpoint documentation to the HTTP API docs based on the current version of the VHAL implementation.
fc8524c
to
cd6d765
Compare
This adds VHAL endpoint documentation to the HTTP API docs based on the current version of the VHAL implementation.