Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ref): add VHAL HTTP API documentation #21

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

ajanon
Copy link
Contributor

@ajanon ajanon commented Jan 16, 2024

This adds VHAL endpoint documentation to the HTTP API docs based on the current version of the VHAL implementation.

@morphis morphis added this to the 1.21.0 milestone Jan 16, 2024
Copy link
Collaborator

@morphis morphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

keirthana pushed a commit to keirthana/anbox-cloud-docs that referenced this pull request Jan 17, 2024
"metadata": {
"value": {
"area_id": 49, # Requested area.
"bytes": [], # Raw bytes value as an 8-bit unsigned integer array.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question I left on the MP, do we need to keep the field when its value is empty? Same for int32_values/int64_values and others.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rework serialization in a follow-up MP.
For now, I prefer to have the documentation reflect what's actually in the code: if we omit the fields in the future, I will update the documentation and remove them (or explain that they may be omitted).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me .

Copy link
Contributor

@jat-canonical jat-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ref/anbox-https-api.md Outdated Show resolved Hide resolved
ref/anbox-https-api.md Outdated Show resolved Hide resolved
@ajanon ajanon force-pushed the vhal_http_api branch 2 times, most recently from 668d3db to 187b8ad Compare January 23, 2024 10:45
@ajanon ajanon requested review from adglkh and keirthana January 23, 2024 14:51
Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@adglkh adglkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"metadata": {
"value": {
"area_id": 49, # Requested area.
"bytes": [], # Raw bytes value as an 8-bit unsigned integer array.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me .

@keirthana keirthana added the documentation Improvements or additions to documentation label Feb 12, 2024
This adds VHAL endpoint documentation to the HTTP API docs based on the current
version of the VHAL implementation.
@keirthana keirthana merged commit 9341496 into canonical:main Feb 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants