Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create AAOS tutorial #78

Merged
merged 5 commits into from
May 31, 2024
Merged

Create AAOS tutorial #78

merged 5 commits into from
May 31, 2024

Conversation

keirthana
Copy link
Collaborator

No description provided.

jat-canonical
jat-canonical approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@jat-canonical jat-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ajanon
ajanon requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@ajanon ajanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo and one question from me.

tutorial/getting-started-aaos.md Outdated Show resolved Hide resolved
tutorial/getting-started-aaos.md Outdated Show resolved Hide resolved
@keirthana keirthana requested review from morphis and ajanon May 30, 2024 17:02
morphis
morphis approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@morphis morphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tutorial/getting-started-aaos.md Show resolved Hide resolved
ajanon
ajanon reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@ajanon ajanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I just have two small questions still.

tutorial/getting-started-aaos.md Outdated Show resolved Hide resolved
tutorial/getting-started-aaos.md Show resolved Hide resolved
ajanon
ajanon approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@ajanon ajanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

tutorial/getting-started-aaos.md Show resolved Hide resolved
@keirthana keirthana merged commit cda4eff into canonical:main May 31, 2024
3 checks passed
@keirthana keirthana deleted the aaos-tutorial branch July 3, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jat-canonical jat-canonical jat-canonical approved these changes

@ajanon ajanon ajanon approved these changes

@morphis morphis morphis approved these changes

@adglkh adglkh Awaiting requested review from adglkh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keirthana @morphis @ajanon @jat-canonical