Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(12-factor-app): add configurations to deploy as 12 factor app [WD-11371] #352

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Aug 26, 2024

Done

  • Added configuration files (rockcraft.yaml, charmcraft.yaml) and deploy.yaml workflow to deploy the website as a 12-factor application.

Issue / Card

Fixes WD-11371

@webteam-app
Copy link

Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reference the charm/lib/charms directory as a library in a remote repository? Otherwise, we end up copying into each website and maintaining becomes very hard.

.github/workflows/deploy.yaml Show resolved Hide resolved
@lorumic
Copy link
Contributor Author

lorumic commented Aug 27, 2024

Can we reference the charm/lib/charms directory as a library in a remote repository? Otherwise, we end up copying into each website and maintaining becomes very hard.

I think we should probably exclude the lib folder and its content from version control. These are libraries that are fetched when running the charmcraft fetch-libs command, so we can consider them as "build artifacts" in a sense.

Regarding the remote repository idea, I don't think that can work, because each website can have different dependencies.

konf/site.yaml Show resolved Hide resolved
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lorumic lorumic merged commit 3c2ae11 into canonical:main Aug 28, 2024
6 checks passed
@lorumic lorumic deleted the 12-factor-app branch August 28, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants