ci: add security scans #1915
Closed
ci: add security scans #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
force-pushed
the
work/secscan
branch
4 times, most recently
from
242cff2
to
a422167
Compare
lengau
commented
Sep 23, 2024
There was a problem hiding this comment.
This is to handle the fact that ops < 2.15.0 has a known CVE
lengau
force-pushed
the
work/secscan
branch
from
a422167
to
9fcb60c
Compare
lengau
force-pushed
the
work/secscan
branch
from
9fcb60c
to
349886b
Compare
tigarmo
reviewed
Sep 24, 2024
mr-cal
approved these changes
Sep 24, 2024
Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
|
Closing this as these are going to go into https://github.com/canonical/starflow. I'll open a separate one that uses the starflow version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two security scanning items:
Snap build error is fixed in #1916
This is the applications version. Compare to the libraries version at canonical/craft-platforms#52
Once approval is provided here, I will upstream to Starbase and reproduce on our other applications.
NOTE: The Starbase version will be commented out below the libraries version, with a note that applications need to switch which version is commented.