-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tgpio test (New) #1239
Open
LiaoU3
wants to merge
10
commits into
main
Choose a base branch
from
add_tgpio_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add tgpio test (New) #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook25
requested changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes to do in the pxus and a couple of minor changes in the python file (mostly style). I have also a few questions, see below
Co-authored-by: Massimiliano <massimiliano.girardi@canonical.com>
Co-authored-by: Massimiliano <massimiliano.girardi@canonical.com>
Co-authored-by: Massimiliano <massimiliano.girardi@canonical.com>
fernando79513
added
the
waiting-for-changes
The review has been completed but the PR is waiting for changes from the author
label
Jul 16, 2024
We are now waiting for #1249 to be merged and we are ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
waiting-for-changes
The review has been completed but the PR is waiting for changes from the author
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add TGPIO test from checkbox-provider-intliotg.
Resolved issues
N/A
Documentation
Please check
README.md
.Tests
https://certification.canonical.com/hardware/202311-32338/submission/368615/
AI
I will add unittest once this is considered an approved PR.