Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconstruct pc sanity test plan (BugFix) #1320

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

xanthein
Copy link
Contributor

@xanthein xanthein commented Jul 4, 2024

Description

Create separate pc-sanity test plan for different LTS release

Resolved issues

OEX86-105

Documentation

Tests

@xanthein xanthein requested a review from a team as a code owner July 4, 2024 08:11
@xanthein xanthein changed the title Reconstruct pc sanity test plan Reconstruct pc sanity test plan (BugFix) Jul 4, 2024
@xanthein
Copy link
Contributor Author

xanthein commented Jul 5, 2024

@KaiChuan-Hsieh @binli can you help to review the PR

Copy link
Contributor

@KaiChuan-Hsieh KaiChuan-Hsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment in-line, thanks.

contrib/pc-sanity/units/pc-sanity/pc-sanity.pxu Outdated Show resolved Hide resolved
contrib/pc-sanity/units/pc-sanity/pc-sanity.pxu Outdated Show resolved Hide resolved
Copy link
Contributor

@binli binli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@KaiChuan-Hsieh KaiChuan-Hsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xanthein xanthein merged commit a8d5e9d into main Jul 16, 2024
9 checks passed
@xanthein xanthein deleted the reconstruct_pc_sanity_plan branch July 16, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants