-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert wan/3gpp-scan test as a automated test (New) #1323
Conversation
convert 3gpp scan test to automated test
convert 3gpp scan test to automated test
add dependency
…nto auto_3gpp_scan_test
add test job dependency
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
+ Coverage 44.18% 44.23% +0.05%
==========================================
Files 359 359
Lines 38813 38853 +40
Branches 6581 6584 +3
==========================================
+ Hits 17148 17187 +39
- Misses 21003 21004 +1
Partials 662 662
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
add one more unit test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments below, and a change request to use template-id
s instead of regex in the test plans.
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
re-structure the 3gpp scan test
fix unit test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for applying all the changes we discussed here and on Mattermost!
- Add a `3gpp-scan` subcommand to the wwan_tests.py script - Create a new `wwan/3gpp-scan-{manufacturer}-{model}-{hw_id}-auto` template job to automatically scan available GSM connections using the new subcommand --------- Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Description
Convert wan/3gpp-scan test as a automated test (New)
Resolved issues
OEMQA-4494
Documentation
N/A
Tests
Please refer following submission for the test results (w/ side loaded provider)
https://certification.canonical.com/hardware/202302-31253/submission/379312/ (Updated on 2024/07/08)