Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap job for zapper-enabled test plan (New) #1352

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

p-gentili
Copy link
Collaborator

@p-gentili p-gentili commented Jul 22, 2024

Description

When a device is hooked up with a Zapper, depending on the previous conditions of the setup, its presence might affect the other test cases, like seen in #1326.

This PR introduces a new bootstrap job, to clear Zapper-related environment before running the actual test plan.

It assumes that the Zapper setup is correctly configured, via zapper setup, since it will unplug USB sticks if not configured for provisioning.

Resolved issues

Resolves CHECKBOX-1481 and #1326.

Documentation

N/A

Tests

See #1352 (comment).

@p-gentili p-gentili changed the title New: bootstrap job for zapper-enabled test plan Bootstrap job for zapper-enabled test plan (New) Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.20%. Comparing base (9409c50) to head (4641c72).
Report is 146 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
+ Coverage   44.18%   44.20%   +0.02%     
==========================================
  Files         359      359              
  Lines       38813    38827      +14     
  Branches     6581     6585       +4     
==========================================
+ Hits        17148    17162      +14     
+ Misses      21003    21002       -1     
- Partials      662      663       +1     
Flag Coverage Δ
checkbox-support 52.70% <100.00%> (+0.13%) ⬆️
provider-base 18.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p-gentili p-gentili marked this pull request as ready for review July 23, 2024 07:40
@p-gentili
Copy link
Collaborator Author

@rmartin013, we'll need to properly configure your setups with zapper setup start or manually editing the Zapper configuration file. I can do it for you remotely.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, if the api PR is approved, please do (re-)test this and merge it

If not feel free to link it

@p-gentili
Copy link
Collaborator Author

Tested on the same environment as the linked issue.

Test case:
1. start zapper streaming (it will "connect" a second monitor)
2. start provided launcher (SRU test-plan)

Expected: `resolution_after_suspend` passes

Running latest beta: FAILED, see https://certification.canonical.com/hardware/202210-30711/submission/382542/test-results/?term=resolution_before_suspend

Running this branch:

[...]
=====[ Bootstrap com.canonical.certification::zapper_capabilities (9/11) ]======
=====[ Bootstrap com.canonical.certification::zapper_reset_setup (10/11) ]======
[...]

PASS, see https://certification.canonical.com/hardware/202210-30711/submission/382558/test-results/?term=resolution_before_suspend

@p-gentili p-gentili merged commit 9a1afd7 into main Jul 25, 2024
19 checks passed
@p-gentili p-gentili deleted the reset-zap-env branch July 25, 2024 15:03
pedro-avalos pushed a commit that referenced this pull request Jul 29, 2024
* Add: zapper reset bootstrap job

* Fix: removed deprecated zapper-enabled job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants