Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New debian validation pipeline (infra) #1369

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Jul 25, 2024

Description

This new workflow builds the debian packages when relevant files are changed.

Resolved issues

We have broken the debian packages twice in the last 2 days

Documentation

N/A

Tests

N/A

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.12%. Comparing base (69a4b09) to head (e0422af).
Report is 126 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1369   +/-   ##
=======================================
  Coverage   45.12%   45.12%           
=======================================
  Files         366      366           
  Lines       39057    39058    +1     
  Branches     6607     6607           
=======================================
+ Hits        17625    17626    +1     
  Misses      20758    20758           
  Partials      674      674           
Flag Coverage Δ
checkbox-support 59.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hook25 Hook25 marked this pull request as ready for review July 25, 2024 15:12
p-gentili
p-gentili previously approved these changes Jul 25, 2024
Copy link
Collaborator

@p-gentili p-gentili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to filter out configurations from the matrix that are not involved.

Since it only takes 4 minutes to run instead of hours debugging problems with dependencies, we can address this later if it's not trivial.

.github/workflows/deb_validator.yaml Show resolved Hide resolved
.github/workflows/deb_validator.yaml Outdated Show resolved Hide resolved
Co-authored-by: Paolo Gentili <paolo.gentili@canonical.com>
@Hook25
Copy link
Collaborator Author

Hook25 commented Jul 25, 2024

I agree that this is subottimal as is, but it does give a nice barrier to trivial mistakes. I will search for a clean solution to only run what is necessary but the metabox one can't be easily adapted to this so I will do it in a follow up

@p-gentili p-gentili enabled auto-merge (squash) July 25, 2024 16:02
Copy link
Collaborator

@p-gentili p-gentili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@p-gentili p-gentili merged commit 0e188c6 into main Jul 25, 2024
41 checks passed
@p-gentili p-gentili deleted the verify_packages_pipeline branch July 25, 2024 16:03
pedro-avalos pushed a commit that referenced this pull request Jul 29, 2024
* New debian validation pipeline

* Fix dependency problem to checkbox-support

---------

Co-authored-by: Paolo Gentili <paolo.gentili@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants