-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New debian validation pipeline (infra) #1369
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1369 +/- ##
=======================================
Coverage 45.12% 45.12%
=======================================
Files 366 366
Lines 39057 39058 +1
Branches 6607 6607
=======================================
+ Hits 17625 17626 +1
Misses 20758 20758
Partials 674 674
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3c11405
to
623aba3
Compare
0dcecf7
to
52e688e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to filter out configurations from the matrix that are not involved.
Since it only takes 4 minutes to run instead of hours debugging problems with dependencies, we can address this later if it's not trivial.
Co-authored-by: Paolo Gentili <paolo.gentili@canonical.com>
I agree that this is subottimal as is, but it does give a nice barrier to trivial mistakes. I will search for a clean solution to only run what is necessary but the metabox one can't be easily adapted to this so I will do it in a follow up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
* New debian validation pipeline * Fix dependency problem to checkbox-support --------- Co-authored-by: Paolo Gentili <paolo.gentili@canonical.com>
Description
This new workflow builds the debian packages when relevant files are changed.
Resolved issues
We have broken the debian packages twice in the last 2 days
Documentation
N/A
Tests
N/A