Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop_session in bootstrap for zapper testplan (BugFix) #1458

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

p-gentili
Copy link
Collaborator

@p-gentili p-gentili commented Sep 9, 2024

WARNING: This modifies com.canonical.certification::sru

Description

The resource desktop_session was not included in the zapper testplan bootstrap section. Also, the zapper-edid job was including a useless template-resource section.

Resolved issues

N/A

Documentation

N/A

Tests

Tested sideloading the provider:

  1. desktop_session is ran as part of bootstrap
  2. zapper/edid is included in the test plan

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.13%. Comparing base (0881101) to head (eb97cd8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1458      +/-   ##
==========================================
+ Coverage   45.87%   46.13%   +0.26%     
==========================================
  Files         367      367              
  Lines       39156    39206      +50     
  Branches     6622     6633      +11     
==========================================
+ Hits        17961    18088     +127     
+ Misses      20504    20421      -83     
- Partials      691      697       +6     
Flag Coverage Δ
provider-base 20.66% <ø> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p-gentili p-gentili merged commit 5ebfbaf into main Sep 9, 2024
43 checks passed
@p-gentili p-gentili deleted the fix-zapper-edid-not-template branch September 9, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants