Add manifest entry for dangerous grade images (new) #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our testing lab, we need to provision some devices with Ubuntu Core images that are set to use the 'dangerous' grade. This will fail the `image/model-grade` test. Add a new `dangerous_grade_core_image` manifest to decide whether or not we should be running this test. It will be run by default (when there is no manifest entry, its value is set to 'False'), but by setting it to True, the test will be skipped.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1541 +/- ##
==========================================
+ Coverage 47.75% 47.76% +0.01%
==========================================
Files 370 370
Lines 39739 39750 +11
Branches 6719 6720 +1
==========================================
+ Hits 18976 18987 +11
Misses 20048 20048
Partials 715 715
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hook25
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In our testing lab, we need to provision some devices with Ubuntu Core
images that are set to use the 'dangerous' grade.
This will fail the
image/model-gradetest.Add a new
dangerous_grade_core_imagemanifest to decide whether or notwe should be running this test.
It will be run by default (when there is no manifest entry, its value is
set to 'False'), but by setting it to True, the test will be skipped.
Resolved issues
Fix #1479
Fix CHECKBOX-1572
Documentation
Tests