Fix GPGPU provider distribution (New) #1542
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-avalos
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
===========================================
+ Coverage 48.00% 91.13% +43.12%
===========================================
Files 371 3 -368
Lines 39837 327 -39510
Branches 6733 38 -6695
===========================================
- Hits 19125 298 -18827
+ Misses 19994 28 -19966
+ Partials 718 1 -717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Ok, the next step should be to get the repository setup part of the |
|
I'm wondering if the compiling should actually be part of |
pedro-avalos
commented
Oct 16, 2024
pedro-avalos
force-pushed
the
fix-gpgpu-provider-distribution
branch
from
19c5320
to
aa87cdc
Compare
These files are created by the system being tested. They shouldn't be pushed to github.
Now gpu-setup is merely installing dependencies for the provider. Ideally, these dependencies will get pulled in by the snap or deb package, and the system will be able to compile the tests. TOOD: With AMD tests being added, this Makefile will need to be skipped if the system being used does not have NVIDIA GPUs.
I'm curious to see if the packaging will succeed with what we have in the Ubuntu repositories. I'm skeptical, though.
The projects are downloaded to `/opt/` but the binaries are symlinked to `/usr/local/sbin`. Need to test if the symlinks are able to find the necessary data files.
The preinst and postinst solution did not work. preinst does not run before the dependency handling occurs.
This should be installed already, but might as well
These are no longer going to be living inside the data directory
pedro-avalos
force-pushed
the
fix-gpgpu-provider-distribution
branch
from
44f8e49
to
d308544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the GPGPU provider depends on the user running a setup script after installing the provider. This script sets up the NVIDIA/AMD repositories to get the required packages from upstream (i.e. CUDA toolkit or ROCm). This has worked so far, but it is negatively affecting the way we test the provider, especially with automated setups.
Resolved issues
Resolves CHECKBOX-1519
Documentation
Tests