Add AMD PMF driver loading validation (New) #1620
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieqq
requested changes
Dec 19, 2024
| import subprocess | ||
|
|
||
|
|
||
| class AMDPMF: |
There was a problem hiding this comment.
I thought that there will be more test cases for AMD PMF driver. Therefore, I would like to use class to make it could add more function.
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
Co-authored-by: Pierre Equoy <pierre.equoy@canonical.com>
2. add and modify docstring 3. change the from amd_pmf to import amd_pmf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AMD PMF (Platform Management Framework) is a new feature that required by client to validate.
Currently, the test plan is only included one loading test, and will be enhanced in the future.
Resolved issues
Internal Jira ticket
Documentation
Tests
manifest false to skip: https://certification.canonical.com/hardware/202001-27667/submission/403122/
AMD PMF isn't loaded: https://certification.canonical.com/hardware/202001-27667/submission/403120/
AMD PMF is loaded: https://certification.canonical.com/hardware/202401-33431/submission/403125/