Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DSS integration tests for CPU and NVIDIA GPU (New) #1633

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

motjuste
Copy link
Contributor

@motjuste motjuste commented Dec 3, 2024

Description

Added integration tests from the data-science-stack repo. These tests need to be run at the very end, and require that DSS is not initialized, because the integration tests themselves initialize and purge DSS and check for relevant success. Integration tests for NVIDIA GPU also require that the relevant k8s plugin is setup.

The Git repo is cloned, the relevant virtual environment is created, and the tests are executed using tox from the virtual environment.

Resolved issues

Documentation

There are no changes to the documentation.

Tests

The relevant DSS workflow run: https://github.com/canonical/checkbox/actions/runs/12143951564

to save ourselves some time...

The job linked above was actually run on a different branch, which consists of commits from this PR, and PR #1634 together. This is because the workflow runs can take a very long time, and while their changes don't overlap, the two PRs are worth testing together.

The failures on testing DSS latest/edge are expected due to a reported issue and do not stem from these changes to Checkbox. The one failure testing DSS latest/stable is during provisioning from Testflinger, before the Checkbox validations are even installed.

@motjuste motjuste force-pushed the CHECKBOX-1667-add-dss-integration-tests branch 3 times, most recently from bca6355 to f558eb1 Compare December 3, 2024 16:22
@motjuste motjuste requested a review from pieqq December 4, 2024 09:37
@motjuste motjuste marked this pull request as ready for review December 4, 2024 09:38
@motjuste motjuste requested a review from a team as a code owner December 4, 2024 09:38
@motjuste motjuste force-pushed the CHECKBOX-1667-add-dss-integration-tests branch from f558eb1 to 9dd778a Compare December 5, 2024 14:15
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I spotted a typo, and I have a question inline below.

this is to catch situations where the script is called with unsupported
arguments.
@motjuste motjuste requested a review from pieqq December 6, 2024 15:30
@motjuste
Copy link
Contributor Author

motjuste commented Dec 6, 2024

The tests have been re-triggered: https://github.com/canonical/checkbox/actions/runs/12201552963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants