Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: update the tbt3 storage-test job command #389

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

baconYao
Copy link
Contributor

Use checkbox-support-usb_read_write script to perform the storage-test testing for Thunderbolt storage in Ubuntu Core image because there's no udisks2 package installed by default.

Description

Describe your changes here:

  • What's the problem solved (briefly, since the issue is where this is elaborated in more detail).
    • The removable_storage_test.py script tries to perform the storage test through dbus.udisks service, however, there's no udisks service in Ubuntu Core image, so the script, removable_storage_test.py, is no longer suitable.
    • Error message
      • FileNotFoundError: [Errno 2] No such file or directory: 'udisks2.udisksctl'

Documentation

  • Automated tests are included for the changed functionality in this PR. If to be merged without tests, please elaborate why.
  • Necessary documentation is provided for the changed functionality in this PR (tests are documentation, too).

Tests

Use checkbox-support-usb_read_write script to perform the storage-test
testing for Thunderbolt storage in Ubuntu Core image because there's no
udisks2 package installed by default.
@baconYao baconYao requested a review from pieqq March 24, 2023 02:08
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pieqq pieqq merged commit 2ae2d46 into canonical:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants