Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker test whitespace, services and version are top level keys #407

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Fix docker test whitespace, services and version are top level keys #407

merged 1 commit into from
Apr 1, 2023

Conversation

xnox
Copy link
Contributor

@xnox xnox commented Mar 31, 2023

Description

Describe your changes here:

  • What's the problem solved (briefly, since the issue is where this is elaborated in more detail).
  • Introduce your implementation approach in a way that helps reviewing it well.

Resolved issues

Note the Jira/Launchpad issue(s) resolved by this PR (Fixes|Resolves ...).

Documentation

  • Automated tests are included for the changed functionality in this PR. If to be merged without tests, please elaborate why.
  • Necessary documentation is provided for the changed functionality in this PR (tests are documentation, too).

Tests

  • Steps to follow for reviewer to run & manually test are provided.
  • A list of what tests were run and on what platform/configuration is provided.

@xnox
Fix docker test whitespace, services and version are top level keys
5dc637d 
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
yphus
yphus approved these changes Apr 1, 2023
View reviewed changes
Copy link
Contributor

@yphus yphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, +1

@yphus yphus merged commit fed0de6 into canonical:main Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yphus yphus yphus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xnox @yphus