-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: set multiple MAC in one BTDEVADDR feature #424
Add: set multiple MAC in one BTDEVADDR feature #424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One minor English fix below.
I'm so sorry I rebased to wrong commit. Should I drop this PR then create a new one? |
If there's problem with your order then you can reset your branch to the same commit as the |
65a5c1a
to
b7988e2
Compare
b7988e2
to
bed8915
Compare
I have fixed it. Thanks for you help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing a link to all the different test cases you've tested, it's really helpful!
Looks good to me.
Description
Describe your changes here:
BTDEVADDR could not set multiple BT MAC addresses at the same time. It will make automatic testing failed, if the test BT server be occupied or not available.
The only impact job is
com.canonical.plainbox::bluetooth/bluetooth_obex_send
.Setting of BTDEVADDR is changing from
to
Resolved issues
Documentation
Tests