Fix: checkbox crash for non-existent usernames and refactor user handling #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch also checks if the provided user is available on the system. See bug on JIRA and unit tests from this patch for details. Fixes: CHECKBOX-597
pieqq
approved these changes
May 12, 2023
yphus
suggested changes
May 12, 2023
yphus
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes a problem where checkbox would crash when controller provided a username that doesn't exists on the controlled system. It also moves the user handling heuristics into a new module and simplifies the existing logic.
See bug on JIRA and unit tests from this patch for details.
Resolved issues
Fixes: CHECKBOX-597
Documentation
The functionality doesn't change so no docs.
Tests
In this patch I provide unit tests for the heuristics.
Moreover the following PR will have a metabox test that will test this as well.
Testing
I tested the branch using a remote/service combo with launchers specifying random combination of existing and non-existent users.
And of course tox + metabox.