Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make a warning about bad secure_id more informative #469

Merged
merged 1 commit into from
May 17, 2023

Conversation

kissiel
Copy link
Contributor

@kissiel kissiel commented May 17, 2023

Description

This adds more context to the InvalidSecureIDError so we can properly test it in metabox.

The secure_id can come from different places this is why I'm not handling it in stages.py directly (by hardcoding the 'c3' transport)

Testing:

Tested by running sessions with different secure_ids.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks great

@kissiel kissiel merged commit 0c9b922 into main May 17, 2023
@kissiel kissiel deleted the better-handling-of-bad-secure-id branch May 17, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants