fix: make network-info jobs require ethtool to be available (bugfix)

[kissiel]

Description

Make network-info jobs require ethtool.
See bug link for details.

Resolved issues

Fixes: : CHECKBOX-626 (#488)

Testing

Tested on a system without the ethtool and now it yields:

==============[ Running job 1 / 1. Estimated time left: 0:00:01 ]===============
-------------------[ Network Information of device 1 (eno1) ]-------------------
ID: com.canonical.certification::networking/info_device1_eno1
Category: com.canonical.plainbox::networking
Job cannot be started because:
 - resource expression "executable.name == 'ethtool'" evaluates to false
Outcome: job cannot be started
Finalizing session that hasn't been submitted anywhere: checkbox-run-2023-05-24T07.16.45
==================================[ Results ]===================================
 ☑ : Enumerate available system executables
 ☑ : Collect information about hardware devices (udev)
 ☐ : Network Information of device 1 (eno1)

And with it installed it proceeds to run.

[pieqq]

Thanks for that fix. A few comments:

• the bug happens with the snap version of Checkbox, even though it seems that ethtool is pulled at build time. Does modifying the packaging meta-data unit helps in that regard?
• the job is skipped (providing zero info about the network) instead of running and providing partial information about the network. Not sure if this is what QA team need.

[kissiel]

Thanks for that fix. A few comments:

• the bug happens with the snap version of Checkbox, even though it seems that ethtool is pulled at build time. Does modifying the packaging meta-data unit helps in that regard?

I'll make sure it is so.

• the job is skipped (providing zero info about the network) instead of running and providing partial information about the network. Not sure if this is what QA team need.

I asked Doug that @ the original bug

[pieqq]

Since the original issue was marked as closed, we might want to close this associated PR.

[kissiel]

Yeah, although it still makes sense to not crash on missing ethtool. Recent releases don't include it by default.

[pieqq]

Any plan for this? Do we close it or not?

[kissiel]

The patch still makes sense IMHO..
The job runs ethtool, but doesn't officially require it.

[Hook25]

+1, this job should require ethtool as it uses it