Checkbox 417/wireless detect #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move dbus import to where it belong
modify mocked input
pieqq
requested changes
Jun 2, 2023
There was a problem hiding this comment.
We are getting there! A few last comments and I think this should be good to land.
Thanks a lot for your patience and perseverance, @diohe0311 !
pieqq
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue is occurs in IoT device while running wireless detect test without WiFi connection.
If there is no WiFi connection, the device didn't turns OFF network module but turns into dormant state, which causing issue.
I add a exception handling to avoid OSError interrupt testing.
(Additionally, there is a indirectly import problem in network_device_info.py ocurrs during testing, this is because the imported module is not the standard module in tox venv.
After discuss with Pierre, Maciej and Massimiliano, since the module is not been used in unit test, the simplest solution is move importing line to where the function is actually needed.)
Resolved issues
https://warthogs.atlassian.net/jira/software/c/projects/CHECKBOX/boards/590?modal=detail&selectedIssue=CHECKBOX-417
Documentation
Tests
$./manage.py test -u (in checkbox/providers/base)
Tested in 10.102.160.211 (Ubuntu 20.04.6) and my laptop.