Add/fix resource debugging and a tests for #665 (BugFix) #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kissiel
approved these changes
Oct 30, 2023
Must be the PR number, but if not on 👻 time, when!? |
Saviq
force-pushed
the
debug-resources
branch
from
82871c1
to
3386240
Compare
Codecov Report
@@ Coverage Diff @@
## main #666 +/- ##
==========================================
- Coverage 34.83% 34.83% -0.01%
==========================================
Files 302 302
Lines 34165 34166 +1
Branches 5909 5909
==========================================
- Hits 11903 11902 -1
- Misses 21697 21698 +1
- Partials 565 566 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kissiel
changed the title
|
/canonical/self-hosted-runners/run-workflows 3386240 |
It referred to the `resource` above.
This helps a lot with debugging expressions.
Saviq
force-pushed
the
debug-resources
branch
from
3386240
to
341f3c0
Compare
|
/canonical/self-hosted-runners/run-workflows 341f3c0 |
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
…nonical#666) * Fix debug in Resource.evaluate() It referred to the `resource` above. * Add a debug statement for matched expressions This helps a lot with debugging expressions. * Add tests for canonical#665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple tests to showcase #665 - one, incorrectly,
@expectedFailure.Also fixes a debug statement and adds one helpful when debugging requirements.