-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move memory_stress_ng from the category memory to stress (Bugfix) #677
Move memory_stress_ng from the category memory to stress (Bugfix) #677
Conversation
@scotthu27 Could you help to explain with more details why we need the category to be correct? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
+ Coverage 34.83% 35.73% +0.89%
==========================================
Files 302 302
Lines 34165 34245 +80
Branches 5909 5916 +7
==========================================
+ Hits 11901 12236 +335
+ Misses 21698 21441 -257
- Partials 566 568 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Note: ignore coverage requirements right now, we are having a small issue with the action, the numbers reported are inaccurate! |
@Hook25 Thank you for your explaination! |
/canonical/self-hosted-runners/run-workflows f2a3577 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and it looks all good!
Given that it's part of the stress-ng-cert-automated nest part, this test will also be run in other test plans such as client-cert-desktop-[18|20|22|24]-04.pxu
and client-cert-odm-desktop-[18|20|22|24]-04.pxu
@LiaoU3 can you sign your commits and re-submit them? https://github.com/canonical/checkbox/blob/main/CONTRIBUTING.md#signed-commits-required |
f2a3577
to
7da0707
Compare
Rename topic to fit the current requirements. |
/canonical/self-hosted-runners/run-workflows 7da0707 |
…gfix) (canonical#677) Modify: move memory_stress_ng from the category memory to stress
…gfix) (canonical#677) Modify: move memory_stress_ng from the category memory to stress
…gfix) (canonical#677) Modify: move memory_stress_ng from the category memory to stress
Description
The job
memory_stress_ng
should be included in thestress
category instead ofmemory
category just like we makecpu_stress_ng_test
intostress
category here. And also it would be easier for someone (like ODM) running the wholestress related test
.Resolved issues
memory_stress_ng
.stress
category.Tests
Since I only changed the category and I didn't change anything with the job, I
list-bootstrapped
the job would be run in each testplan includingmemory_stress_ng
com.canonical.certification::stress-ng-cert-automated
Before
After
Diff
com.canonical.certification::server-memory
Before
After
####Diff
com.canonical.certification::20.04-server-full
Before
After
Diff
com.canonical.certification::20.04-server-soc-cert
Before
After
Diff
com.canonical.certification::server-cert-ubuntucore-20
Before
After
Diff
com.canonical.certification::20.04-virtual-machine-full
Before
After
Diff