Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed pyotherside to qml-module-io-thp-pyotherside (bugfix) #742

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Sep 21, 2023

Description

pyotherside was just a transitional dummy package to install qml-module-io-thp-pyotherside. It was removed in mantic so we must update the dependency now to match what is actually in the repos.

Resolved issues

N/A

Documentation

N/A

Tests

N/A

The package was just a transitional dummy package that depended
on qml-module-io-thp-pyotherside. It was removed in mantic so
we must to update the name now
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #742 (a3c6d7a) into main (9be7d86) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage   33.50%   33.50%           
=======================================
  Files         303      303           
  Lines       34823    34823           
  Branches     5979     5979           
=======================================
  Hits        11666    11666           
  Misses      22615    22615           
  Partials      542      542           
Flag Coverage Δ
provider-certification-client 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@yphus yphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the package name works from xenial to mantic. +1

@Hook25 Hook25 merged commit e120173 into main Sep 21, 2023
8 checks passed
@Hook25 Hook25 deleted the change_pyotherside_dependency_name branch September 21, 2023 14:00
Copy link
Contributor

@kissiel kissiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been checking this ;)

qml-module-io-thp-pyotherside/xenial 1.4.0-2 amd64
  asynchronous Python 3 Bindings for Qt 5 (QML plugin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants