Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version check to camera quality test (Bugfix) #833

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

fernando79513
Copy link
Collaborator

The camera quality job now includes a requirement for ubuntu version >=22.04

Description

The camera quality test was created only for 22.04 versions onwards, but it was being run also for previous versions. We have added a check to ensure it is only run for the corresponding versions.

Resolved issues

Documentation

Tests

Running the camera quality test in versions earlier than 22.04 should not be executed.

==============[ Running job 5 / 5. Estimated time left: 0:00:20 ]===============
------------[ Webcam brisque score for XXX ]-------------
ID: com.canonical.certification::camera/camera-quality_video0
Category: com.canonical.plainbox::camera
Job cannot be started because:
 - resource expression "lsb.release >= '22.04'" evaluates to false
Outcome: job cannot be started

The camera quality job now includes a requirement for ubuntu
version >=22.04
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c854ed) 35.38% compared to head (a6547d4) 35.38%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #833   +/-   ##
=======================================
  Coverage   35.38%   35.38%           
=======================================
  Files         303      303           
  Lines       34239    34239           
  Branches     5917     5917           
=======================================
  Hits        12114    12114           
  Misses      21559    21559           
  Partials      566      566           
Flag Coverage Δ
provider-base 4.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yphus yphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1

@fernando79513 fernando79513 merged commit 62834c4 into main Nov 23, 2023
10 checks passed
@fernando79513 fernando79513 deleted the fix-camera-quality-version-usage branch November 23, 2023 15:10
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
Added version check to camera quality test

The camera quality job now includes a requirement for ubuntu
version >=22.04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants