Dont require gpg pass when running tests (BugFix) #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
=======================================
Coverage 35.38% 35.38%
=======================================
Files 303 303
Lines 34239 34239
Branches 5917 5917
=======================================
Hits 12114 12114
Misses 21559 21559
Partials 566 566
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Previously when the tests run, if the host had a GPG key in its databse that was protected by a password, the operator was asked to provide the password. This was due to subprocess.call not being mocked properly in the provider_manager tests. This patch adds the mocking.
kissiel
force-pushed
the
dont-require-gpg-pass-when-running-tests
branch
from
d8a69d8
to
2e67421
Compare
Hook25
approved these changes
Nov 25, 2023
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
properly mock subprocess calls in test_provider_manager Previously when the tests run, if the host had a GPG key in its databse that was protected by a password, the operator was asked to provide the password. This was due to subprocess.call not being mocked properly in the provider_manager tests. This patch adds the mocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously when the tests run, if the host had a GPG key in its databse that was protected by a password, the operator was asked to provide the password. This was due to subprocess.call not being mocked properly in the provider_manager tests.
Tests
The test module is what gets fixed here.