Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted camera quality test to 22.04 (Bugfix) #862

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

fernando79513
Copy link
Collaborator

Description

The camera-quality test was being run with newer versions of ubuntu ( > 22.04) but opencv was only installed in 22.04. We have restricted this behavior so this test is only included for 22.04 until we figure out a way to properly manage this.

Resolved issues

Documentation

Tests

The camera quality test should not be run for versions of checkbox =! 22.04

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4319b97) 35.69% compared to head (66ce346) 35.69%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #862   +/-   ##
=======================================
  Coverage   35.69%   35.69%           
=======================================
  Files         303      303           
  Lines       34250    34250           
  Branches     5917     5917           
=======================================
  Hits        12226    12226           
  Misses      21459    21459           
  Partials      565      565           
Flag Coverage Δ
provider-base 5.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yphus yphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A proper fix requires adding support for a syntax like >= 22.04 in the packaging meta data units. Restricting to 22.04 makes sense until deb packaging can also install opencv on 22.04+ automatically

+1

@yphus yphus merged commit 86047a6 into main Dec 1, 2023
9 checks passed
@yphus yphus deleted the restricted-camera-quality-to-22 branch December 1, 2023 16:07
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants