Pin urllib to <2.0 for Metabox (BugFix) #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
* pin urllib to a version that works with pylxd * update tutorial for metabox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR pins urllib to a version lower than 2.0. This is to circumvent a known problem of pylxd. More context here.
Resolved issues
Fixes: [#868]
Fixes: CHECKBOX-1068
Documentation
Updated docs to use non-dangerous virtualenv target.
Tests
Tested by running Metabox on a fresh host (VM).