fix mocks in tests for remote_session_assistant (BugFix) #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
==========================================
+ Coverage 36.54% 36.56% +0.02%
==========================================
Files 310 310
Lines 34634 34634
Branches 5964 5964
==========================================
+ Hits 12656 12664 +8
+ Misses 21408 21400 -8
Partials 570 570
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hook25
approved these changes
Dec 14, 2023
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Jan 9, 2024
* fix mocks in tests for remote_session_assistant * add unittests for is_passwordless_sudo
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
* fix mocks in tests for remote_session_assistant * add unittests for is_passwordless_sudo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes 3 unittests that assumed the test will be run on a typical Ubuntu box, which LP builders are clearly not.
Tests
To test it I've recreated the conditions on LP, meaning I "removed" sudo and made the
guess_normal_useralways raise the exception.