Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger and needs constraint to promotion workflow (infra) #921

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Jan 9, 2024

Description

We have decided that the promotion to the beta channel of the snap is governed by the moving target that is the beta branch. Once that branch is moved, the current edge version of the snap/deb must be promoted to stable. This introduces the mechanism to the beta promotion workflow along a sanity check to avoid race conditions (namely, the last "green" run of the daily build must have happened on the commit pointed by beta, else something went wrong!).

Resolved issues

Resolves: CHECKBOX-1056

Documentation

N/A (This is just the workflow work, it works as described before)

Tests

The mechanism was partially validated offline, it is easier to iterate online on the last details

@Hook25 Hook25 changed the title Add needs constraint to promotion workflow (infra) Add trigger and needs constraint to promotion workflow (infra) Jan 9, 2024
Copy link
Contributor

@kissiel kissiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The double apt update is needed indeed. Once for potential curl installation, and the other after we add the PPA.

Good changes, +1

@kissiel kissiel merged commit db453f5 into main Jan 9, 2024
3 checks passed
@kissiel kissiel deleted the autopromotion_workflow branch January 9, 2024 19:25
LiaoU3 pushed a commit to LiaoU3/checkbox that referenced this pull request Mar 20, 2024
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants