Add "Hygon Dhyana" to CPUs recognized by cpuid.py + small refactor (New) #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
==========================================
+ Coverage 37.50% 37.60% +0.09%
==========================================
Files 313 313
Lines 34809 34810 +1
Branches 5983 5982 -1
==========================================
+ Hits 13055 13089 +34
+ Misses 21174 21141 -33
Partials 580 580
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kissiel
force-pushed
the
hygon-dhyana-in-cpuid
branch
from
6285d55
to
7eef520
Compare
mreed8855
approved these changes
Jan 11, 2024
Closed
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
…ew) (canonical#928) * move decoding of cpuid to a dedicated funciton * Add Hygon Dhyana Plus to identified CPUs in cpuid * add the first test for cpuid * formatting improvements * add tests for not recognizing * add tests for the main() of cpuid * make the assertions python 3.5 friendly
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
…ew) (canonical#928) * move decoding of cpuid to a dedicated funciton * Add Hygon Dhyana Plus to identified CPUs in cpuid * add the first test for cpuid * formatting improvements * add tests for not recognizing * add tests for the main() of cpuid * make the assertions python 3.5 friendly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Amidst shenanigans with the reformatting of some of the modules the PR with the addition of Hygon Dhyana got closed.
This PR brings the addition back.
But... the
cpuid.pyis long overdue for a makeover. Let's start by extracting the function that decodes the cpuid and adding the first unit tests for that thing.Resolved issues
#529
SERVCERT-1147
Tests
Yeah, the first one :)Quite a few unit tests.