Pad every frontend snap with workaround part (infra) #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kissiel
previously approved these changes
Jan 12, 2024
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
* Add new workaround part to snapcraft.yaml * Added header to file and updated comment
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
* Add new workaround part to snapcraft.yaml * Added header to file and updated comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
snapd has added a minimal 16kb size of snap files in the following commit (canonical/snapd@5bae3c1)
but the automated review tool unaware that. This causes very small snaps to be automatically rejected by the review tool because they are automatically padded by snapcraft but not by the cross-verification process that the review tool does.
To work around this I propose introducing a new part that links back to the upstream bug, making the build pass for now.
Resolved issues
Failing daily builds
Documentation
This patch comes with a comment explaining why the part is there and when it should be removed.
Tests
I have built the snap offline and it is passing the validator (also, in the last few days due to another bug, the only snaps that were passing the validator were the snaps who included some other build log, making them slightly bigger!)