Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration-test target broken due to pytest 7.3.1 behavior change related to testpaths config #4183

Closed
blackboxsw opened this issue Jun 13, 2023 · 0 comments · Fixed by #4184
Closed

integration-test target broken due to pytest 7.3.1 behavior change related to testpaths config #4183

blackboxsw opened this issue Jun 13, 2023 · 0 comments · Fixed by #4184
Labels
bug Something isn't working correctly new An issue that still needs triage

Comments

@blackboxsw
Copy link
Collaborator

Bug report

pytest 7.3.2 changed treatment of testpaths to now always load conftest from the tox configured testpaths. this breaks our integration-tests because our configured testpaths in tox.ini points to tests/unittests which carries with it a dependency on responses that is unneeded for our integration-tests target. This behavior breaks all of our jenkins test runners which don't need to express responses as a dependency.

This issue is known in pytest issue: #11104 and will likely be reverted in the coming week and introduced as a separate config feature in a major release.

Steps to reproduce the problem

tox -e integration-test  # results in a traceback module not found `reponses`

Environment details

cloud-init logs
@blackboxsw blackboxsw added bug Something isn't working correctly new An issue that still needs triage labels Jun 13, 2023
blackboxsw added a commit to blackboxsw/cloud-init that referenced this issue Jun 13, 2023
@blackboxsw
integration-tests: pin pytest 7.3.1 to avoid adverse testpaths behavior
d6d8ad0 
pytest 7.3.2 changed treatment of `testpaths` config which forced
test/unittest/conftest.py module load in our integration-tests
toxenv. Upstream bug is tracking their planned revert/fix for this
regression. Pin 7.3.1 in the meantime.

Fixes canonical#4183
@blackboxsw blackboxsw mentioned this issue Jun 13, 2023
Merged
3 tasks
blackboxsw added a commit to blackboxsw/cloud-init that referenced this issue Jun 13, 2023
@blackboxsw
tests: pin pytest 7.3.1 to avoid adverse testpaths behavior
3dd82e2 
pytest 7.3.2 changed treatment of `testpaths` config which forced
test/unittest/conftest.py module load in our integration-tests
toxenv. Upstream bug is tracking their planned revert/fix for this
regression. Pin 7.3.1 in the meantime.

Fixes canonical#4183
blackboxsw added a commit to blackboxsw/cloud-init that referenced this issue Jun 13, 2023
@blackboxsw
tests: pin pytest 7.3.1 to avoid adverse testpaths behavior
ee1949d 
pytest 7.3.2 changed treatment of `testpaths` config which forced
test/unittest/conftest.py module load in our integration-tests
toxenv. Upstream bug is tracking their planned revert/fix for this
regression. Pin 7.3.1 in the meantime.

Fixes canonical#4183
blackboxsw added a commit that referenced this issue Jun 13, 2023
@blackboxsw
tests: pin pytest 7.3.1 to avoid adverse testpaths behavior (#4184)
d1268cd 
pytest 7.3.2 changed treatment of `testpaths` config which forced
test/unittest/conftest.py module load in our integration-tests
toxenv. Upstream bug is tracking their planned revert/fix for this
regression. Pin 7.3.1 in the meantime.

Fixes #4183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly new An issue that still needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

integration-tests: pin pytest 7.3.1 to avoid adverse testpaths behavior blackboxsw/cloud-init
1 participant
@blackboxsw