fix(tests): use regex to avoid focal whitespace in jinja debug test #5335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
force-pushed
the
tests-focal-debug-whitespace
branch
from
120b534 to
3d0adfb
Compare
holmanb
approved these changes
May 27, 2024
holmanb
pushed a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Daily focal builds were failing on unmatched whitespace indents in jinja debug tests
https://code.launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+build/28465099
Here's a build success run using this changeset:
https://code.launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+recipebuild/3732927
Test Steps
The daily recipe build for focal will take care of building this properly
https://code.launchpad.net/~cloud-init-dev/+recipe/cloud-init-daily-focal
Checklist
Merge type