-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate away from deprecation warnings #5856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeprecationWarning: Testing an element's truth value will always return True in future versions canonicalGH-5175
Warning: PytestCollectionWarning: cannot collect test class 'TestUpdatePackageSources' because it has a __init__ constructor canonicalGH-5175
Deprecation warning: DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior. Refs: https://docs.python.org/3/library/tarfile.html#tarfile-extraction-filter https://peps.python.org/pep-0706/ canonicalGH-5175
…ical#5856) DeprecationWarning: Accessing jsonschema.__version__ is deprecated and will be removed in a future release. Use importlib.metadata directly to query for jsonschema's version. canonicalGH-5174
…onical#5856) Deprecated message: DeprecationWarning: Passing a schema to Validator.iter_errors is deprecated and will be removed in a future release. Call validator.evolve(schema=new_schema).iter_errors(...) instead. Refs: https://github.com/python-jsonschema/jsonschema/releases/tag/v4.0.0 canonicalGH-5175
aciba90
force-pushed
the
5175-deprecation-warnings
branch
from
November 7, 2024 13:00
eac1437
to
9bdbca9
Compare
TheRealFalcon
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM!
@aciba90 , anything else needed here? |
Nope, let me merge. |
aciba90
added a commit
that referenced
this pull request
Nov 13, 2024
aciba90
added a commit
that referenced
this pull request
Nov 13, 2024
aciba90
added a commit
that referenced
this pull request
Nov 13, 2024
DeprecationWarning: Testing an element's truth value will always return True in future versions GH-5175
aciba90
added a commit
that referenced
this pull request
Nov 13, 2024
Warning: PytestCollectionWarning: cannot collect test class 'TestUpdatePackageSources' because it has a __init__ constructor GH-5175
aciba90
added a commit
that referenced
this pull request
Nov 13, 2024
Deprecation warning: DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior. Refs: https://docs.python.org/3/library/tarfile.html#tarfile-extraction-filter https://peps.python.org/pep-0706/ GH-5175
aciba90
added a commit
that referenced
this pull request
Nov 13, 2024
DeprecationWarning: Accessing jsonschema.__version__ is deprecated and will be removed in a future release. Use importlib.metadata directly to query for jsonschema's version. GH-5174
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
DeprecationWarning: Testing an element's truth value will always return True in future versions canonicalGH-5175
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
Warning: PytestCollectionWarning: cannot collect test class 'TestUpdatePackageSources' because it has a __init__ constructor canonicalGH-5175
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
Deprecation warning: DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior. Refs: https://docs.python.org/3/library/tarfile.html#tarfile-extraction-filter https://peps.python.org/pep-0706/ canonicalGH-5175
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
…ical#5856) DeprecationWarning: Accessing jsonschema.__version__ is deprecated and will be removed in a future release. Use importlib.metadata directly to query for jsonschema's version. canonicalGH-5174
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
…onical#5856) Deprecated message: DeprecationWarning: Passing a schema to Validator.iter_errors is deprecated and will be removed in a future release. Call validator.evolve(schema=new_schema).iter_errors(...) instead. Refs: https://github.com/python-jsonschema/jsonschema/releases/tag/v4.0.0 canonicalGH-5175
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
…5856) canonicalGH-5175 Signed-off-by: Mathieu Marchand <mathieu.marchand@canonical.com>
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
…nonical#5856) canonicalGH-5175 Signed-off-by: Mathieu Marchand <mathieu.marchand@canonical.com>
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
DeprecationWarning: Testing an element's truth value will always return True in future versions canonicalGH-5175 Signed-off-by: Mathieu Marchand <mathieu.marchand@canonical.com>
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
Warning: PytestCollectionWarning: cannot collect test class 'TestUpdatePackageSources' because it has a __init__ constructor canonicalGH-5175 Signed-off-by: Mathieu Marchand <mathieu.marchand@canonical.com>
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
Deprecation warning: DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior. Refs: https://docs.python.org/3/library/tarfile.html#tarfile-extraction-filter https://peps.python.org/pep-0706/ canonicalGH-5175 Signed-off-by: Mathieu Marchand <mathieu.marchand@canonical.com>
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
…ical#5856) DeprecationWarning: Accessing jsonschema.__version__ is deprecated and will be removed in a future release. Use importlib.metadata directly to query for jsonschema's version. canonicalGH-5174 Signed-off-by: Mathieu Marchand <mathieu.marchand@canonical.com>
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 21, 2024
…onical#5856) Deprecated message: DeprecationWarning: Passing a schema to Validator.iter_errors is deprecated and will be removed in a future release. Call validator.evolve(schema=new_schema).iter_errors(...) instead. Refs: https://github.com/python-jsonschema/jsonschema/releases/tag/v4.0.0 canonicalGH-5175 Signed-off-by: Mathieu Marchand <mathieu.marchand@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase & merge
See individual commits
Fixes GH-5175
Additional Context
#5855 was discovered while working on this issue. I decided to split it as a separate work item, because it requires a broader discussion.
Test Steps
Merge type