Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Mark broken daily check with FIXME request #5884

Closed

Conversation

stappersg
Copy link
Contributor

The daily CI action is broken for a long time. It is visible in our "upstream" git repository, a.k.a. the Canonical git repo, and all the forks of it. It emits "We don't care".

To prevent getting further used to "Yeah, the CI tests fail", modified the CI test into something that runs successfully.

Proposed Commit Message

<type>(optional scope): <summary>  # no more than 72 characters

A description of what the change being made is and why it is being
made if the summary line is insufficient.  This should be wrapped at
72 characters.

If you need to write multiple paragraphs, feel free.

Fixes GH-NNNNN (GitHub Issue number. Remove line if irrelevant)
LP: #NNNNNN (Launchpad bug number. Remove line if irrelevant)

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

The daily CI action is broken for a long time. It is visible
in our "upstream" git repository, a.k.a. the Canonical git repo,
and all the forks of it. It emits "We don't care".

To prevent getting further used to "Yeah, the CI tests fail",
modified the CI test into something that runs successfully.
@holmanb
Copy link
Member

holmanb commented Nov 18, 2024

@stappersg this proposal doesn't actually solve anything. It should be a straightforward fix, just haven't had time yet.

@holmanb holmanb closed this Nov 18, 2024
@stappersg
Copy link
Contributor Author

stappersg commented Nov 18, 2024 via email

@stappersg
Copy link
Contributor Author

stappersg commented Dec 14, 2024

It should be a straightforward fix

Bluf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants