test: pytestify "tests/unittests/config/test_cc_timezone.py" #5885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as Contributor docs: improved mermaid diagram. Add "MaheshG11" as contributor docs: improved mermaid diagram. Add "MaheshG11" as Contributor
23 tasks
holmanb
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Thanks for this change @MaheshG11! I requested one small change inline, but otherwise this looks good.
holmanb
approved these changes
Nov 19, 2024
mathmarchand
pushed a commit
to mathmarchand/cloud-init-onb1204
that referenced
this pull request
Nov 29, 2024
…al#5885) Refactors the code in the file "tests/unittests/config/test_cc_timezone.py" using pytest. This helps remove dependance of this test on "tests/unittests/helpers.py:FileSystemMockingTestCase" Fixes: part of canonicalGH-5760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
This change removes the dependance of the test on FileSystemMockingTestCase and replaces it with fakefilesystem, a pytest fixture located in "tests/unittest/conftest".
Fixes: part of #5760
Test Steps
pytest tests/unittests/config/test_cc_timezone.pyin main repositoryMerge type