Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: re-decrement expected webhook events #5894

Merged
merged 1 commit into from
Nov 21, 2024
Merged

test: re-decrement expected webhook events #5894

merged 1 commit into from
Nov 21, 2024

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

test: re-decrement expected webhook events

Tried to fix in aedb7f97 , but there are two events (start and stop)
per module

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@TheRealFalcon
test: re-decrement expected webhook events
fa0b769 
Tried to fix in aedb7f9 , but there are two events (start and stop)
per module
holmanb
holmanb approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, should have tested. It fails with assert 51 > 51, so 50 should work. Thanks!

@holmanb holmanb merged commit 9f2cae7 into canonical:main Nov 21, 2024
22 checks passed
mathmarchand pushed a commit to mathmarchand/cloud-init-onb1204 that referenced this pull request Nov 29, 2024
@TheRealFalcon @mathmarchand
test: re-decrement expected webhook events (canonical#5894)
a8835b7 
Tried to fix in aedb7f9 , but there are two events (start and stop)
per module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmanb holmanb holmanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheRealFalcon @holmanb