Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validate-config command #4

Merged
merged 1 commit into from
Jan 25, 2023
Merged

add validate-config command #4

merged 1 commit into from
Jan 25, 2023

Conversation

dstathis
Copy link
Contributor

@dstathis dstathis commented Jan 24, 2023 •
edited
Loading

Issue

cos-tool needs to validate Prometheus config files.

Solution

Added the validate-config command.

Testing Instructions

cos-tool validate-config path/to/config

Release Notes

cos-tool now validates Prometheus config files

rbarry82
rbarry82 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@rbarry82 rbarry82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, though I wonder about it validating the entire config. It's good. I also wonder if we should try to allow for more atomic validation of rules, too

cmd/root/root.go Show resolved Hide resolved
@dstathis dstathis merged commit fb48333 into canonical:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sed-i sed-i sed-i left review comments

@rbarry82 rbarry82 rbarry82 approved these changes

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstathis @sed-i @rbarry82