Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement _get_build_for() in LifecycleService #394

Closed
lengau opened this issue Jul 23, 2024 · 1 comment · Fixed by #414
Closed

Implement _get_build_for() in LifecycleService #394

lengau opened this issue Jul 23, 2024 · 1 comment · Fixed by #414
Assignees
@lengau
Labels
Enhancement New feature or request triaged

Comments

@lengau
Copy link
Contributor

lengau commented Jul 23, 2024

What needs to get done

The application should be able to provide its own build_for value to craft-parts by moving this part of _init_lifecycle_manager to its own method.

Why it needs to get done

Charmcraft needs to allow multi-arch builds to fix canonical/charmcraft#1697. The logic in chramcraft would be to select an architecture to guarantee something that looks like cross-compiles.
@lengau lengau added Enhancement New feature or request triaged labels Jul 23, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3145.

This message was autogenerated

@lengau lengau mentioned this issue Jul 23, 2024
Closed
lengau added a commit that referenced this issue Aug 12, 2024
@lengau
feat(lifecycle): break out _get_build_for method
f585663 
Fixes #394
@lengau lengau mentioned this issue Aug 12, 2024
Merged
3 tasks
@lengau lengau linked a pull request Aug 12, 2024 that will close this issue
feat(lifecycle): break out _get_build_for method #414
Merged
3 tasks
lengau added a commit that referenced this issue Aug 13, 2024
@lengau
feat(lifecycle): break out _get_build_for method (#414)
947e1b4 
Fixes #394
@lengau lengau self-assigned this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lengau lengau

Labels
Enhancement New feature or request triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lifecycle): break out _get_build_for method canonical/craft-application
1 participant
@lengau