Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use urllib.request.getproxies() to pass system proxies to the provider #422

Closed
lengau opened this issue Aug 16, 2024 · 1 comment
Closed
Labels
Enhancement New feature or request triaged

Comments

@lengau
Copy link
Contributor

lengau commented Aug 16, 2024

What needs to get done

Use getproxies() to forward the proxy environment variables.

Forward both all-caps and lowercase versions of the variables

Why it needs to get done

This sidesteps the problem of us having to worry about other ways of setting proxies while also handling both the upper case and lower case versions in a secure manner.

@lengau lengau added Enhancement New feature or request triaged labels Aug 16, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3245.

This message was autogenerated

lengau added a commit that referenced this issue Aug 16, 2024
lengau added a commit that referenced this issue Aug 16, 2024
lengau added a commit that referenced this issue Aug 26, 2024
lengau added a commit that referenced this issue Aug 29, 2024
@lengau lengau closed this as completed in a49a3ea Aug 30, 2024
linostar pushed a commit to linostar/craft-application that referenced this issue Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests

1 participant