fix: inject aliased snaps into build environment #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-cal
force-pushed
the
work/CRAFT-3212/snap-aliases
branch
from
e68695e to
383c5f1
Compare
mr-cal
force-pushed
the
work/CRAFT-3212/snap-aliases
branch
from
383c5f1 to
92184b4
Compare
tigarmo
approved these changes
Sep 13, 2024
lengau
reviewed
Sep 13, 2024
lengau
approved these changes
Sep 13, 2024
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
mr-cal
force-pushed
the
work/CRAFT-3212/snap-aliases
branch
from
92184b4 to
9726f51
Compare
linostar
pushed a commit
to linostar/craft-application
that referenced
this pull request
Dec 4, 2024
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?Inject snaps into the build environment using their aliased name.
I tested and confirmed this works with the reproducer in canonical/snapcraft#4683.
However, I tested with a locally built snap, so it had no assertions. The secondary failure in craft-providers with
snap ackwill probably start occurring when testing with a signed snap from the store.The craft-providers fix is probably changing this line to
snap_name.split('_')[0].Fixes #411