Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Build dependencies in Readme #529

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

imranzaheer612
Copy link
Contributor

  • Added commands to install build dependencies for the raft and dqlite library .
  • Changes added to the Chinese read-me too.

Copy link
Contributor

@cole-miller cole-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll need you to sign the Canonical CLA (requires a Launchpad account) before we can merge this.

Comment on lines +84 to +87
```
sudo apt install autoconf libuv1-dev liblz4-dev libtool pkg-config build-essential libsqlite3-dev
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to have some context before this, like:

On a Debian-like Linux system, you can install all the build dependencies with:

I'm not sure what to do about the Chinese README, since I can't translate the new text. @growdu would you be willing to help out here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry that I only saw this message now. The current Chinese description is OK.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #529 (a0f9fab) into master (837eeee) will not change coverage.
The diff coverage is n/a.

❗ Current head a0f9fab differs from pull request most recent head aeb8b03. Consider uploading reports for the commit aeb8b03 to get more accurate results

@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   61.35%   61.35%           
=======================================
  Files          34       34           
  Lines        6816     6816           
  Branches     2024     2024           
=======================================
  Hits         4182     4182           
  Misses       1347     1347           
  Partials     1287     1287           

@cole-miller cole-miller merged commit 641fdfd into canonical:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants