Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor leader.c to fix stack growth in handle_exec_sql #697

Merged
merged 13 commits into from
Oct 15, 2024
Merged

Refactor leader.c to fix stack growth in handle_exec_sql #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
222adba
Rewrite leader__barrier and leader__exec
cole-miller Sep 2, 2024
f8a5aee
Rewrite handle_exec_sql_next
cole-miller Sep 2, 2024
5f139a2
Add a regression test
cole-miller Sep 2, 2024
478ef8d
Merge remote-tracking branch 'canonical/master' into leader-pseudo-co…
cole-miller Oct 8, 2024
fc98dcc
Fix after merge
cole-miller Oct 8, 2024
63e0ede
Fix handling of error from exec_apply
cole-miller Oct 10, 2024
c7d70ad
Docs
cole-miller Oct 10, 2024
8ae4d3f
Remove remaining traces of old request IDs
cole-miller Oct 11, 2024
9ff34d6
Address review comments
cole-miller Oct 11, 2024
f9c4ca1
No more bottom halves
cole-miller Oct 11, 2024
1f3ac63
Tighten up semicolons test
cole-miller Oct 11, 2024
de2758d
Bump up the number of statements
cole-miller Oct 11, 2024
06992a6
Remove confused FIXME
cole-miller Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ basic_dqlite_sources = \
src/format.c \
src/fsm.c \
src/gateway.c \
src/id.c \
src/leader.c \
src/lib/addr.c \
src/lib/buffer.c \
Expand Down
3 changes: 1 addition & 2 deletions src/conn.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,6 @@ int conn__start(struct conn *c,
struct raft *raft,
struct uv_stream_s *stream,
struct raft_uv_transport *uv_transport,
struct id_state seed,
conn_close_cb close_cb)
{
int rv;
Expand All @@ -311,7 +310,7 @@ int conn__start(struct conn *c,
c->transport.data = c;
c->uv_transport = uv_transport;
c->close_cb = close_cb;
gateway__init(&c->gateway, config, registry, raft, seed);
gateway__init(&c->gateway, config, registry, raft);
rv = buffer__init(&c->read);
if (rv != 0) {
goto err_after_transport_init;
Expand Down
2 changes: 0 additions & 2 deletions src/conn.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include "lib/transport.h"

#include "gateway.h"
#include "id.h"
#include "message.h"
#include "raft.h"

Expand Down Expand Up @@ -50,7 +49,6 @@ int conn__start(struct conn *c,
struct raft *raft,
struct uv_stream_s *stream,
struct raft_uv_transport *uv_transport,
struct id_state seed,
conn_close_cb close_cb);

/**
Expand Down
Loading
Loading