Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement the access token handling for device authorization flow #5

Merged
merged 6 commits into from
Mar 15, 2024
Merged

feat: implement the access token handling for device authorization flow #5

merged 6 commits into from
Mar 15, 2024

Conversation

wood-push-melon
Copy link

This pull request tries to implement the access token handling for device authorization flow. It is generally from the upstream work in this pull request.

@wood-push-melon wood-push-melon changed the title IAM-704 Implement the access token handling for device authorization flow feat: Implement the access token handling for device authorization flow Mar 7, 2024
@wood-push-melon wood-push-melon changed the title feat: Implement the access token handling for device authorization flow feat: implement the access token handling for device authorization flow Mar 7, 2024
@wood-push-melon wood-push-melon requested a review from a team March 8, 2024 04:16
@wood-push-melon wood-push-melon marked this pull request as ready for review March 8, 2024 04:16
shipperizer
shipperizer reviewed Mar 8, 2024
View reviewed changes
fosite_test.go Outdated Show resolved Hide resolved
fosite_test.go Show resolved Hide resolved
handler/oauth2/flow_generic_code_token.go Outdated Show resolved Hide resolved
nsklikas
nsklikas reviewed Mar 8, 2024
View reviewed changes
Copy link

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. I am not 100% sold on the token endpoint refactor, let's talk about it.

device_user_request.go Outdated Show resolved Hide resolved
handler.go Outdated Show resolved Hide resolved
handler/oauth2/flow_generic_code_token.go Outdated Show resolved Hide resolved
handler/oauth2/flow_generic_code_token.go Outdated Show resolved Hide resolved
handler/oauth2/flow_generic_code_token.go Show resolved Hide resolved
handler/rfc8628/token_handler.go Outdated Show resolved Hide resolved
shipperizer
shipperizer reviewed Mar 12, 2024
View reviewed changes
handler/oauth2/flow_authorize_code_token.go Outdated Show resolved Hide resolved
handler/oauth2/flow_generic_code_token.go Outdated Show resolved Hide resolved
handler/rfc8628/token_handler.go Outdated Show resolved Hide resolved
nsklikas
nsklikas reviewed Mar 13, 2024
View reviewed changes
handler/oauth2/flow_generic_code_token.go Outdated Show resolved Hide resolved
handler/oauth2/flow_generic_code_token.go Outdated Show resolved Hide resolved
handler/rfc8628/token_handler.go Show resolved Hide resolved
nsklikas
nsklikas approved these changes Mar 14, 2024
View reviewed changes
Copy link

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other a minor comment you can disregard

handler/oauth2/flow_generic_code_token.go Show resolved Hide resolved
@shipperizer
Copy link

@wood-push-melon all good from me, bundle up the chore: resolve comments into the 50f92c7 commit if u can, or squash them into one and change the message accordingly, then good to go

@wood-push-melon wood-push-melon merged commit 222821e into canonical Mar 15, 2024
5 checks passed
@wood-push-melon wood-push-melon deleted the IAM-704 branch March 15, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shipperizer shipperizer shipperizer left review comments

@nsklikas nsklikas nsklikas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wood-push-melon @shipperizer @nsklikas