Tests: Replace RSA cert by ECDSA cert #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 17, 2021 13:33
Because of golang/go#20058. key & cert generation: $ openssl version OpenSSL 1.1.1f 31 Mar 2020 $ openssl ecparam -out cluster.key -name secp256r1 -genkey $ openssl req -new -key cluster.key -x509 -nodes -days 10000 -out \ cluster.crt -addext "subjectAltName = IP.1:127.0.0.1, DNS:local.test" You are about to be asked to enter information that will be incorporated into your certificate request. What you are about to enter is what is called a Distinguished Name or a DN. There are quite a few fields but you can leave some blank For some fields there will be a default value, If you enter '.', the field will be left blank. ----- Country Name (2 letter code) [AU]:. State or Province Name (full name) [Some-State]:. Locality Name (eg, city) []:. Organization Name (eg, company) [Internet Widgits Pty Ltd]:. Organizational Unit Name (eg, section) []:. Common Name (e.g. server FQDN or YOUR name) []:dqlite-test Email Address []:.
freeekanayaka
approved these changes
Nov 17, 2021
|
Ah yeah, that makes a lot of sense, extremely poor performance of RSA in Go on ARM is why we switched to ECDSA in LXD in the first place (at Google's request due to Chromebooks being extremely slow). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of golang/go#20058
Speeds up the tests on armhf machines by quite a lot and lowers the chance of them timing out.
key & cert generation:
Also replaced the ppa in the actions.