Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add MAAS server API endpoint interactions #43

Merged
merged 1 commit into from
Jan 4, 2024
Merged

feat: add MAAS server API endpoint interactions #43

merged 1 commit into from
Jan 4, 2024

Conversation

skatsaounis
Copy link
Collaborator

This PR includes the following:

  • Update the initial interface signature so that Get can return a byte slice. This is needed since get can return a mixture of int, string or boolean values
  • Implement the existing API
  • Expose the API interaction through the client

NOTE: It is user responsibility to unmarshal the returned value to an appropriate type.

@skatsaounis
Copy link
Collaborator Author

This PR is also a prerequisite for canonical/terraform-provider-maas#132

SK1Y101
SK1Y101 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@SK1Y101 SK1Y101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skatsaounis skatsaounis merged commit 7be8be8 into canonical:master Jan 4, 2024
3 checks passed
@skatsaounis skatsaounis deleted the add-maas-server-implementation branch January 4, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SK1Y101 SK1Y101 SK1Y101 approved these changes

@troyanov troyanov Awaiting requested review from troyanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skatsaounis @SK1Y101