Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add events API endpoint interaction #54

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

sachin120
Copy link
Contributor

Add Events API endpoint

@sachin120 sachin120 force-pushed the events branch 3 times, most recently from 2a0092d to 6a6a664 Compare January 24, 2024 01:55
Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sachin120. After reviewing your PR I found some issues that I commented/suggested a modification inline. Please take a look :)

entity/events.go Outdated Show resolved Hide resolved
entity/event/types.go Outdated Show resolved Hide resolved
entity/events.go Outdated Show resolved Hide resolved
entity/events.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thank you for yet another one!

@skatsaounis skatsaounis merged commit adb547d into canonical:master Jan 24, 2024
3 checks passed
@sachin120 sachin120 deleted the events branch January 24, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants